tutorial working across languages#618
Conversation
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Hey @ashb155! A couple of comments on this from playing around with it :)
|
|
Would you also want to look into opening a PR in Scribe-i18n with the strings that are needed for the tutorial? CC @prince-0408 and @angrezichatterbox for discussions about Scribe-i18n for Scribe-Android - let's continue to make sure that we have all the strings in that are needed for the apps in Scribe-i18n 👋 |
|
hi @andrewtavis, thanks for your review and detailed comments, will have a look and work on them also with regards to the PR for Scribe-i18n, sounds good, how about I hardcode the required strings as of now (as done in the PR), and later on once finalized we could maybe have a PR for i18n |
|
Hard coding now and then migrating them to Scribe-i18n and then updating Scribe-i18n within the Android app is the exact thing we'd do, @ashb155 😊 Thanks so much! Looking forward to further commits! |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR updates the quick tutorial to dynamically adapt its prompts, hints, and expected inputs based on the user's active Scribe keyboard language, resolving the issue of users being forced to use the German layout.
Key Changes:
TutorialContent.ktto supply localized words ("Mother"/"Father", gender tags) and hints for all 8 supported languages.BroadcastReceiverinTutorialNavigator.ktto instantly update the tutorial text if the user switches keyboards mid-tutorial.Related issue
Closes #616